docs(backlog): two follow-ups from the 2026-05-30 merge session#385
Conversation
Bad code: PLATFORM_wesley-gen-test-crate-builder-duplication.md Four consumer-crate builder fns in tests/generation.rs each ship ~40 lines of overlapping Cargo.toml/lib.rs/dep-declaration boilerplate. The PR #383 speedup work had to touch all four identically when threading CARGO_TARGET_DIR through; every future harness change pays the same cost. Proposes a single ConsumerCrateBuilder so a fifth generated-output path is a ~5-line call instead of a ~40-line copy. Cool idea: PLATFORM_prettier-before-cargo-hook-ordering.md The pre-commit hook still runs the expensive cargo verify step before the cheap prettier + markdownlint step. PR #383's auto-stage fix removed the worst case (no more abort+manual-restage), but the ordering itself means markdown-only commits still pay the cold cargo cost when prettier could have decided the hook can short- circuit. Proposes flipping prettier ahead of cargo. Neither blocks 0025 Phase 2; both are PLATFORM cleanup that pays for itself the first time anyone touches the same paths again.
|
Warning Review limit reached
More reviews will be available in 27 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo backlog documentation files added: one identifying duplicated consumer-crate builder boilerplate across wesley-gen tests and proposing centralization; another proposing pre-commit hook reordering to execute fast checks before expensive cargo verification, with risk assessment and expected commit-type deltas. ChangesBacklog Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/method/backlog/bad-code/PLATFORM_wesley-gen-test-crate-builder-duplication.md`:
- Around line 54-55: The statement claiming "Not a behavior change" about
removing the PID segment from the crate-dir layout is incorrect; update the
documentation text that describes crate path construction (the "crate-dir layout
(drop the PID segment; use only the label/purpose)" note and the related
sentences around it) to say this is behavior-preserving only if
uniqueness/isolation invariants are maintained (e.g., deterministic unique
labeling or explicit tempdir guarantees); explicitly call out that dropping the
PID changes crate path semantics and may affect test isolation/collision under
parallel runs or label reuse, and apply the same rewording to the other
occurrence covering the same crate path/PID change (the block referenced at the
other occurrence).
- Around line 13-16: Remove the unstable "line ~..." annotations and keep only
stable symbol references: keep the function names write_basic_generated_crate,
write_consumer_smoke_crate, write_contract_host_smoke_crate,
write_optic_binding_smoke_crate (optionally append a permalink/commit hash if
you need a fixed anchor), i.e., edit the list entries to drop the line numbers
and replace them with just the function names (or function name + permalink),
and scan the surrounding text for any other hard-coded source line pointers to
remove or replace similarly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 91f8adbc-b185-42ae-b0a1-99d43c3c2f5f
📒 Files selected for processing (2)
docs/method/backlog/bad-code/PLATFORM_wesley-gen-test-crate-builder-duplication.mddocs/method/backlog/cool-ideas/PLATFORM_prettier-before-cargo-hook-ordering.md
|
Activity Summary for Code Lawyer pass on PR #385.
Self-audit found no additional issues beyond the PR review threads. Local validation performed:
All known unresolved review threads have been resolved via GraphQL. |
1 participant
Summary
Two backlog cards that fell out of patterns I noticed during the PR #382 + #383 + jedit #33 merge session but didn't act on. Both are PLATFORM cleanup; neither blocks Echo 0025 Phase 2.
Test plan
Summary by CodeRabbit